Differential D15791 Diff 55072 source/blender/makesrna/intern/rna_scene.c

Changeset View

Standalone View

source/blender/makesrna/intern/rna_scene.c

This file is larger than 256 KB, so syntax highlighting is disabled by default.

Show First 20 Lines • Show All 5,811 Lines • ▼ Show 20 Lines	# endif
prop = RNA_def_property(srna, "use_cineon_log", PROP_BOOLEAN, PROP_NONE);		prop = RNA_def_property(srna, "use_cineon_log", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, NULL, "cineon_flag", R_IMF_CINEON_FLAG_LOG);		RNA_def_property_boolean_sdna(prop, NULL, "cineon_flag", R_IMF_CINEON_FLAG_LOG);
RNA_def_property_ui_text(prop, "Log", "Convert to logarithmic color space");		RNA_def_property_ui_text(prop, "Log", "Convert to logarithmic color space");
RNA_def_property_update(prop, NC_SCENE \| ND_RENDER_OPTIONS, NULL);		RNA_def_property_update(prop, NC_SCENE \| ND_RENDER_OPTIONS, NULL);

prop = RNA_def_property(srna, "cineon_black", PROP_INT, PROP_NONE);		prop = RNA_def_property(srna, "cineon_black", PROP_INT, PROP_NONE);
RNA_def_property_int_sdna(prop, NULL, "cineon_black");		RNA_def_property_int_sdna(prop, NULL, "cineon_black");
RNA_def_property_range(prop, 0, 1024);		RNA_def_property_range(prop, 0, 1024);
RNA_def_property_ui_text(prop, "B", "Log conversion reference blackpoint");		RNA_def_property_ui_text(prop, "Black", "Log conversion reference blackpoint");
RNA_def_property_update(prop, NC_SCENE \| ND_RENDER_OPTIONS, NULL);		RNA_def_property_update(prop, NC_SCENE \| ND_RENDER_OPTIONS, NULL);

prop = RNA_def_property(srna, "cineon_white", PROP_INT, PROP_NONE);		prop = RNA_def_property(srna, "cineon_white", PROP_INT, PROP_NONE);
RNA_def_property_int_sdna(prop, NULL, "cineon_white");		RNA_def_property_int_sdna(prop, NULL, "cineon_white");
RNA_def_property_range(prop, 0, 1024);		RNA_def_property_range(prop, 0, 1024);
RNA_def_property_ui_text(prop, "W", "Log conversion reference whitepoint");		RNA_def_property_ui_text(prop, "White", "Log conversion reference whitepoint");
RNA_def_property_update(prop, NC_SCENE \| ND_RENDER_OPTIONS, NULL);		RNA_def_property_update(prop, NC_SCENE \| ND_RENDER_OPTIONS, NULL);

prop = RNA_def_property(srna, "cineon_gamma", PROP_FLOAT, PROP_NONE);		prop = RNA_def_property(srna, "cineon_gamma", PROP_FLOAT, PROP_NONE);
RNA_def_property_float_sdna(prop, NULL, "cineon_gamma");		RNA_def_property_float_sdna(prop, NULL, "cineon_gamma");
RNA_def_property_range(prop, 0.0f, 10.0f);		RNA_def_property_range(prop, 0.0f, 10.0f);
RNA_def_property_ui_text(prop, "G", "Log conversion gamma");		RNA_def_property_ui_text(prop, "Gamma", "Log conversion gamma");
RNA_def_property_update(prop, NC_SCENE \| ND_RENDER_OPTIONS, NULL);		RNA_def_property_update(prop, NC_SCENE \| ND_RENDER_OPTIONS, NULL);

/* multiview */		/* multiview */
		mont29Unsubmitted Not Done Inline Actions We still need proper formal definition of those in `BLT_translation.h`, all i18n contexts should be handled in a same way, to also ensure that the python api is aware of them. mont29: We still need proper formal definition of those in `BLT_translation.h`, all i18n contexts…
		pioverfourAuthorUnsubmitted Done Inline Actions Understood! So it’s not an issue to add contexts just for one-shot uses like this? I really didn’t see what existing contexts could be used unambiguously. For the “generic” ones I added, I felt like they could be reused at later points but for cineon, not so sure :D Anyway I’ll create a `BLT_I18NCONTEXT_CINEON` context if that makes sense. pioverfour: Understood! So it’s not an issue to add contexts just for one-shot uses like this? I really…
		mont29Unsubmitted Not Done Inline Actions Actually just talked with our UI team, we generally discouraged single letters labels, unless very very common widely accepted cases (like X/Y/Z/W for coordinates, or R/G/B/A for colors). So here proper fix would rather be to replace those by full labels (`Black`, etc.) instead. mont29: Actually just talked with our UI team, we generally discouraged single letters labels, unless…
		pioverfourAuthorUnsubmitted Done Inline Actions Even better! :D I guess that means versioning is needed? pioverfour: Even better! :D I guess that means versioning is needed?
		pioverfourAuthorUnsubmitted Done Inline Actions Replying to myself, no versioning is needed because the prop name doesn’t change. pioverfour: Replying to myself, no versioning is needed because the prop name doesn’t change.
prop = RNA_def_property(srna, "views_format", PROP_ENUM, PROP_NONE);		prop = RNA_def_property(srna, "views_format", PROP_ENUM, PROP_NONE);
RNA_def_property_enum_sdna(prop, NULL, "views_format");		RNA_def_property_enum_sdna(prop, NULL, "views_format");
RNA_def_property_enum_items(prop, rna_enum_views_format_items);		RNA_def_property_enum_items(prop, rna_enum_views_format_items);
RNA_def_property_enum_funcs(prop, NULL, NULL, "rna_ImageFormatSettings_views_format_itemf");		RNA_def_property_enum_funcs(prop, NULL, NULL, "rna_ImageFormatSettings_views_format_itemf");
RNA_def_property_ui_text(prop, "Views Format", "Format of multiview media");		RNA_def_property_ui_text(prop, "Views Format", "Format of multiview media");
RNA_def_property_update(prop, NC_SCENE \| ND_RENDER_OPTIONS, NULL);		RNA_def_property_update(prop, NC_SCENE \| ND_RENDER_OPTIONS, NULL);

prop = RNA_def_property(srna, "stereo_3d_format", PROP_POINTER, PROP_NONE);		prop = RNA_def_property(srna, "stereo_3d_format", PROP_POINTER, PROP_NONE);
▲ Show 20 Lines • Show All 2,448 Lines • Show Last 20 Lines