Differential D1166 Diff 5520 intern/cycles/render/tile.cpp

Changeset View

Standalone View

intern/cycles/render/tile.cpp

Context not available.
	#include "tile.h"	#include "tile.h"

	#include "util_algorithm.h"	#include "util_algorithm.h"
		#include "util_hilbert.h"
	#include "util_types.h"	#include "util_types.h"

	CCL_NAMESPACE_BEGIN	CCL_NAMESPACE_BEGIN
		sergeyUnsubmitted Not Done Inline Actions Can it be more meaningful name than just a single letter? Same applies to the cases below. sergey: Can it be more meaningful name than just a single letter? Same applies to the cases below.
		sergeyUnsubmitted Not Done Inline Actions Braces around the block. sergey: Braces around the block.
		sergeyUnsubmitted Not Done Inline Actions This will fail for viewport renders, i.e. sergey: This will fail for viewport renders, i.e.
		sergeyUnsubmitted Not Done Inline Actions `d >> 1` sergey: `d >> 1`
		sergeyUnsubmitted Not Done Inline Actions `d >>= 2` sergey: `d >>= 2`
		sergeyUnsubmitted Not Done Inline Actions Can we have more readable names for the direction? Like, enum { DIRECTION_LEFT, DIRECTION_TOP, }; or something similar? sergey: Can we have more readable names for the direction? Like, enum { DIRECTION_LEFT…
		sergeyUnsubmitted Not Done Inline Actions Braces. sergey: Braces.
Context not available.
	int64_t cordx = max(1, params.width/resolution);	int64_t cordx = max(1, params.width/resolution);
	int64_t cordy = max(1, params.height/resolution);	int64_t cordy = max(1, params.height/resolution);
	int64_t mindist = INT_MAX;	int64_t mindist = INT_MAX;

	int64_t centx = cordx / 2, centy = cordy / 2;	int64_t centx = cordx / 2, centy = cordy / 2;

		sergeyUnsubmitted Not Done Inline Actions This is to be calculated for only `TILE_HILBERT` it seems, no need to calculate it for all the tile orders. sergey: This is to be calculated for only `TILE_HILBERT` it seems, no need to calculate it for all the…
		int64_t hilbert_n;
		if(tile_order == TILE_HILBERT) {
		hilbert_n = hilbert_roundpow2(max((params.width + tile_size.x - 1) / tile_size.x, (params.height + tile_size.y - 1) / tile_size.y));
		sergeyUnsubmitted Not Done Inline Actions Could also become an util_ function. sergey: Could also become an util_ function.
		}

	for(iter = state.tiles.begin(); iter != state.tiles.end(); iter++) {	for(iter = state.tiles.begin(); iter != state.tiles.end(); iter++) {
	if(iter->device == logical_device && iter->rendering == false) {	if(iter->device == logical_device && iter->rendering == false) {
	Tile &cur_tile = *iter;	Tile &cur_tile = *iter;
		sergeyUnsubmitted Not Done Inline Actions This doesn't follow code style. sergey: This doesn't follow code style.
		sergeyUnsubmitted Not Done Inline Actions Picky: Prefer not to have quesitons in comments, statements are usually cleaner to follow. Like, "Check whether center of spiral was reached.". Applies to few places here. sergey: Picky: Prefer not to have quesitons in comments, statements are usually cleaner to follow. Like…
Context not available.
	case TILE_BOTTOM_TO_TOP:	case TILE_BOTTOM_TO_TOP:
	distx = cordx + cur_tile.y;	distx = cordx + cur_tile.y;
	break;	break;
		case TILE_HILBERT:
		distx = hilbert_xy2d(hilbert_n, cur_tile.x / tile_size.x, cur_tile.y / tile_size.y);
		break;
	default:	default:
	break;	break;
	}	}
Context not available.
		sergeyUnsubmitted Not Done Inline Actions Please apply this separately. Can go to master now, but please always use mustage (curly ;) brackets. sergey: Please apply this separately. Can go to master now, but please always use mustage (curly ;)…