Page MenuHome
Differential D16631 Diff 58313 source/blender/makesrna/intern/rna_nodetree.c

Changeset View

Standalone View

View Options

source/blender/makesrna/intern/rna_nodetree.c

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 9,974 Lines • ▼ Show 20 Lines
{ {
PropertyRNA *prop; PropertyRNA *prop;
static const EnumPropertyItem rna_node_geometry_collection_info_transform_space_items[] = { static const EnumPropertyItem rna_node_geometry_collection_info_transform_space_items[] = {
{GEO_NODE_TRANSFORM_SPACE_ORIGINAL, {GEO_NODE_TRANSFORM_SPACE_ORIGINAL,
"ORIGINAL", "ORIGINAL",
0, 0,
"Original", "Original",
"Output the geometry relative to the collection offset"}, "Output the geometry as instances relative to the collection offset"},
{GEO_NODE_TRANSFORM_SPACE_RELATIVE, {GEO_NODE_TRANSFORM_SPACE_RELATIVE,
"RELATIVE", "RELATIVE",
0, 0,
"Relative", "Relative",
"Bring the input collection geometry into the modified object, maintaining the relative " "Bring the input collection as geometry instances into the modified object, maintaining "
"position between the objects in the scene"}, "the relative position between the objects in the scene"},
HooglyBooglyUnsubmitted
Done
Inline Actions

I left out these two changes, since they made this text a bit more complicated, and I don't think that's necessary.

I also tweaked the description below to clarify it a bit

HooglyBoogly: I left out these two changes, since they made this text a bit more complicated, and I don't…
{0, NULL, 0, NULL, NULL}, {0, NULL, 0, NULL, NULL},
}; };
RNA_def_struct_sdna_from(srna, "NodeGeometryCollectionInfo", "storage"); RNA_def_struct_sdna_from(srna, "NodeGeometryCollectionInfo", "storage");
prop = RNA_def_property(srna, "transform_space", PROP_ENUM, PROP_NONE); prop = RNA_def_property(srna, "transform_space", PROP_ENUM, PROP_NONE);
RNA_def_property_enum_items(prop, rna_node_geometry_collection_info_transform_space_items); RNA_def_property_enum_items(prop, rna_node_geometry_collection_info_transform_space_items);
RNA_def_property_ui_text(prop, "Transform Space", "The transformation of the geometry output"); RNA_def_property_ui_text(
prop,
"Transform Space",
"The transformation of the instances output. The internal geometry doesn't change");
HooglyBooglyUnsubmitted
Not Done
Inline Actions

I would keep this one, but the other changes aren't necessarily an improvement IMO.

It's helpful to use a different wording in tooltips compared to UI text, that way they don't just say the same thing.

In the end, the purpose of the node is to retrieve geometry from a collection. It just happens to use instances as a format

HooglyBoogly: I would keep this one, but the other changes aren't necessarily an improvement IMO. It's…
ModerAuthorUnsubmitted
Done
Inline Actions

wanted to clarify that the transformations will be applied to instances. But if you think about it, it probably doesn’t matter to the user whether the instances are transformed, or the geometry in them?

Moder: wanted to clarify that the transformations will be applied to instances. But if you think about…
HooglyBooglyUnsubmitted
Not Done
Inline Actions

Yes, I see your point. I think it's relevant for most advanced uses.
Mainly I just don't want all of the "geometry" words in the tooltips to be replaced with "instances" since "geometry" is a more beginner-friendly word IMO.
But updating for improved correctness and detail could still make sense

HooglyBoogly: Yes, I see your point. I think it's relevant for most advanced uses. Mainly I just don't want…
HooglyBooglyUnsubmitted
Done
Inline Actions

Internal geometry don't -> The internal geometry doesn't

HooglyBoogly: `Internal geometry don't` -> `The internal geometry doesn't`
RNA_def_property_update(prop, NC_NODE | NA_EDITED, "rna_Node_update_relations"); RNA_def_property_update(prop, NC_NODE | NA_EDITED, "rna_Node_update_relations");
} }
static void def_geo_proximity(StructRNA *srna) static void def_geo_proximity(StructRNA *srna)
{ {
static const EnumPropertyItem target_element_items[] = { static const EnumPropertyItem target_element_items[] = {
{GEO_NODE_PROX_TARGET_POINTS, {GEO_NODE_PROX_TARGET_POINTS,
"POINTS", "POINTS",
▲ Show 20 Lines • Show All 3,011 Lines • Show Last 20 Lines