Page MenuHome
Differential D14365 Diff 59272 source/blender/draw/intern/mesh_extractors/extract_mesh.hh

Changeset View

Standalone View

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh.hh

Show First 20 Lines • Show All 383 Lines • ▼ Show 20 Lines
void *mesh_extract_buffer_get(const MeshExtract *extractor, MeshBufferList *mbuflist); void *mesh_extract_buffer_get(const MeshExtract *extractor, MeshBufferList *mbuflist);
eMRIterType mesh_extract_iter_type(const MeshExtract *ext); eMRIterType mesh_extract_iter_type(const MeshExtract *ext);
const MeshExtract *mesh_extract_override_get(const MeshExtract *extractor, const MeshExtract *mesh_extract_override_get(const MeshExtract *extractor,
bool do_hq_normals, bool do_hq_normals,
bool do_single_mat); bool do_single_mat);
void mesh_render_data_face_flag(const MeshRenderData *mr, void mesh_render_data_face_flag(const MeshRenderData *mr,
const BMFace *efa, const BMFace *efa,
int cd_ofs, BMUVOffsets offsets,
HooglyBooglyUnsubmitted
Done
Inline Actions
const BMFace *efa,
- const UVMap_Offsets offsets,
+ UVMap_Offsets offsets,
EditLoopData *eattr);

In a function's declaration (not its definition), declaring a variable that's passed by value const doesn't do anything, so it's more misleading than helpful

HooglyBoogly: In a function's declaration (not its definition), declaring a variable that's passed by value…
BaardaapAuthorUnsubmitted
Done
Inline Actions

old habits die hard. My old C++ teacher back in university went ballistic if the declaration and definition differed ;-)

Baardaap: old habits die hard. My old C++ teacher back in university went ballistic if the declaration…
HooglyBooglyUnsubmitted
Done
Inline Actions

I generally agree that it's nice to have them the same, there was some discussion about it a while ago though and this was the conclusion, so best to stay consistent I thiink

HooglyBoogly: I generally agree that it's nice to have them the same, there was some discussion about it a…
EditLoopData *eattr); EditLoopData *eattr);
void mesh_render_data_loop_flag(const MeshRenderData *mr, void mesh_render_data_loop_flag(const MeshRenderData *mr,
BMLoop *l, BMLoop *l,
int cd_ofs, BMUVOffsets offsets,
EditLoopData *eattr); EditLoopData *eattr);
void mesh_render_data_loop_edge_flag(const MeshRenderData *mr, void mesh_render_data_loop_edge_flag(const MeshRenderData *mr,
BMLoop *l, BMLoop *l,
int cd_ofs, BMUVOffsets offsets,
EditLoopData *eattr); EditLoopData *eattr);
extern const MeshExtract extract_tris; extern const MeshExtract extract_tris;
extern const MeshExtract extract_tris_single_mat; extern const MeshExtract extract_tris_single_mat;
extern const MeshExtract extract_lines; extern const MeshExtract extract_lines;
extern const MeshExtract extract_lines_with_lines_loose; extern const MeshExtract extract_lines_with_lines_loose;
extern const MeshExtract extract_lines_loose_only; extern const MeshExtract extract_lines_loose_only;
extern const MeshExtract extract_points; extern const MeshExtract extract_points;
Show All 36 Lines