Page MenuHome
Differential D2274 Diff 7568 source/blender/gpu/gawain/immediate.c

Changeset View

Standalone View

View Options

source/blender/gpu/gawain/immediate.c

Context not available.
return vertex_ct % 2 == 0; return vertex_ct % 2 == 0;
case GL_LINE_STRIP: case GL_LINE_STRIP:
case GL_LINE_LOOP: case GL_LINE_LOOP:
return vertex_ct >= 2; return vertex_ct > 2; // otherwise why bother?
case GL_TRIANGLES: case GL_TRIANGLES:
return vertex_ct % 3 == 0; return vertex_ct % 3 == 0;
case GL_TRIANGLE_STRIP: case GL_TRIANGLE_STRIP:
case GL_TRIANGLE_FAN: case GL_TRIANGLE_FAN:
return vertex_ct >= 3; return vertex_ct > 3; // otherwise why bother?
#ifdef WITH_GL_PROFILE_COMPAT #ifdef WITH_GL_PROFILE_COMPAT
case GL_QUADS: case GL_QUADS:
return vertex_ct % 4 == 0; return vertex_ct % 4 == 0;
merwinUnsubmitted
Done
Inline Actions

Function owns the returned memory, so lifetime is ok... but the values are only good for a very short (undetermined) time. Calling again in the same thread or a different thread trashes the data.

I don't think we don't need this function.

merwin: Function owns the returned memory, so lifetime is ok... but the values are only good for a very…
Context not available.
immUniform4f("color", rgb[0], rgb[1], rgb[2], 1.0f); immUniform4f("color", rgb[0], rgb[1], rgb[2], 1.0f);
} }
void immUniformColor3fvAlpha(float rgb[3], float alpha)
{
immUniform4f("color",rgb[0], rgb[1], rgb[2], alpha);
}
void immUniformColor4fv(const float rgba[4]) void immUniformColor4fv(const float rgba[4])
{ {
immUniform4f("color", rgba[0], rgba[1], rgba[2], rgba[3]); immUniform4f("color", rgba[0], rgba[1], rgba[2], rgba[3]);
Context not available.
immUniformColor4ub(rgba[0], rgba[1], rgba[2], rgba[3]); immUniformColor4ub(rgba[0], rgba[1], rgba[2], rgba[3]);
} }
void immUniformColor4f(float r, float g, float b, float a)
{
immUniform4f("color", r, g, b, a);
}
void immUniform1i(const char *name, const unsigned int data) void immUniform1i(const char *name, const unsigned int data)
{ {
int loc = glGetUniformLocation(imm.bound_program, name); int loc = glGetUniformLocation(imm.bound_program, name);
Context not available.