Page MenuHome

Benjamin Summerton (define-private-public)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 15 2016, 3:26 AM (325 w, 3 d)

Recent Activity

Dec 27 2016

Benjamin Summerton (define-private-public) added a comment to T49043: replace OpenGL immediate mode in Blender 2.8.

@Mike Erwin (merwin) I'd like to thank you for helping me with the few diffs that I made, but I'm going to have to sign off from helping with the blender project right now. I have some other priorities that I need to focus on right now. I'd like to come back and help sometime down the road, but I have too much on my plate right now.

Dec 27 2016, 5:07 AM · EEVEE & Viewport, BF Blender: 2.8

Dec 5 2016

Benjamin Summerton (define-private-public) added a comment to T49043: replace OpenGL immediate mode in Blender 2.8.

I'm going to be working on paint_stroke.c for now.

Dec 5 2016, 2:02 AM · EEVEE & Viewport, BF Blender: 2.8

Nov 25 2016

Benjamin Summerton (define-private-public) added a comment to D2377: OpenGL: convert anim_channel_defines.c to new imm mode.

@Anthony Edlin (krash) : I usually do that grep -rn ... thing to trace function calls, but this one was a little more difficult for me. Thanks,

Nov 25 2016, 1:29 AM · BF Blender: 2.8
Benjamin Summerton (define-private-public) updated the diff for D2377: OpenGL: convert anim_channel_defines.c to new imm mode.
  • Moved over an fdrawline() call
Nov 25 2016, 1:25 AM · BF Blender: 2.8

Nov 24 2016

Benjamin Summerton (define-private-public) updated D2364: Replacing UI_view2d_scrollsers_draw() to immedaite mode.
Nov 24 2016, 5:13 AM
Benjamin Summerton (define-private-public) updated D2377: OpenGL: convert anim_channel_defines.c to new imm mode.
Nov 24 2016, 5:12 AM · BF Blender: 2.8
Benjamin Summerton (define-private-public) added a comment to D2377: OpenGL: convert anim_channel_defines.c to new imm mode.

So this was a pretty simple fix over. I wasn't able to test it (yes I know, I'm a bad person) because I don't really know where it's used in the program, or how to bring up the code. I tried tracing it, but I couldn't get functions like acf_generic_channel_backdrop() to be called. If someone knows how to do that, please tell me.

Nov 24 2016, 5:12 AM · BF Blender: 2.8
Benjamin Summerton (define-private-public) retitled D2377: OpenGL: convert anim_channel_defines.c to new imm mode from to This should move over anim_channel_defines.c. Please checke the notes for some of my comments..
Nov 24 2016, 5:07 AM · BF Blender: 2.8
Benjamin Summerton (define-private-public) added a comment to T49043: replace OpenGL immediate mode in Blender 2.8.

I'm going to take anim_channels_defines.c in the meantime actually. I need to talk to merwin before moving on with the other two things I said I was going to do.

Nov 24 2016, 4:37 AM · EEVEE & Viewport, BF Blender: 2.8

Nov 22 2016

Benjamin Summerton (define-private-public) updated the diff for D2363: Moved UI_view2_multi_grid_draw() to Gawain.
  • Merge branch 'blender2.8' into imm.view2d.c.UI_view2d_multi_grid_draw
  • removed unused variables
  • added for a case where "cur spans just over grid lines"
  • Fixing a case where to need to incmrent "i"
Nov 22 2016, 9:45 PM · BF Blender: 2.8

Nov 21 2016

Benjamin Summerton (define-private-public) added a comment to T49043: replace OpenGL immediate mode in Blender 2.8.

I'm going to start on interface_regions.c if there are no takers. I'm skipping text_draw.c for now, so if anyone else wants it. It's up for grabs,.

Nov 21 2016, 2:11 AM · EEVEE & Viewport, BF Blender: 2.8
Benjamin Summerton (define-private-public) abandoned D2372: Cleaning up the leftover bits for view2d.c.

Talked with merwin in the IRC, said we shouldn't touched text colors right now. Will look into that matrix thingy later.

Nov 21 2016, 1:59 AM
Benjamin Summerton (define-private-public) added a comment to D2372: Cleaning up the leftover bits for view2d.c.

Two things:

Nov 21 2016, 1:52 AM
Benjamin Summerton (define-private-public) retitled D2372: Cleaning up the leftover bits for view2d.c from to Cleaning up the leftover bits for view2d.c.
Nov 21 2016, 1:48 AM
Benjamin Summerton (define-private-public) updated the diff for D2364: Replacing UI_view2d_scrollsers_draw() to immedaite mode.
  • Merge branch 'blender2.8' into imm.view2d.c.UI_view2d_scrollers_draw
  • Merge branch 'blender2.8' into imm.view2d.c.UI_view2d_scrollers_draw
  • small cleanup
Nov 21 2016, 1:23 AM
Benjamin Summerton (define-private-public) updated the diff for D2363: Moved UI_view2_multi_grid_draw() to Gawain.
  • Merge branch 'blender2.8' into imm.view2d.c.UI_view2d_multi_grid_draw
  • small code cleanup
Nov 21 2016, 1:19 AM · BF Blender: 2.8

Nov 20 2016

Benjamin Summerton (define-private-public) updated the diff for D2363: Moved UI_view2_multi_grid_draw() to Gawain.
  • only draw axis once now
  • Removed the double negative
  • Fixed vertex counting
  • small simplification
Nov 20 2016, 12:13 AM · BF Blender: 2.8

Nov 19 2016

Benjamin Summerton (define-private-public) added a comment to T49043: replace OpenGL immediate mode in Blender 2.8.

Could someone mark that on the wiki for me? I don't have an account there yet.

Nov 19 2016, 4:57 AM · EEVEE & Viewport, BF Blender: 2.8

Nov 18 2016

Benjamin Summerton (define-private-public) added a comment to T49043: replace OpenGL immediate mode in Blender 2.8.

does editors/space_text/text_draw.c have any takers? I'd like to work on it next after I'm done with view2d.c.

Nov 18 2016, 9:42 PM · EEVEE & Viewport, BF Blender: 2.8
Benjamin Summerton (define-private-public) updated D2364: Replacing UI_view2d_scrollsers_draw() to immedaite mode.
Nov 18 2016, 9:40 PM
Benjamin Summerton (define-private-public) updated the diff for D2363: Moved UI_view2_multi_grid_draw() to Gawain.
  • Fixed issue causing Gawain to assert
Nov 18 2016, 7:21 PM · BF Blender: 2.8
Benjamin Summerton (define-private-public) updated the diff for D2364: Replacing UI_view2d_scrollsers_draw() to immedaite mode.
  • only grabs color once now.
Nov 18 2016, 7:37 AM
Benjamin Summerton (define-private-public) added reviewers for D2364: Replacing UI_view2d_scrollsers_draw() to immedaite mode: Mike Erwin (merwin), Anthony Edlin (krash).

Please review this. Please give me a response for the comment at line 1765.

Nov 18 2016, 5:07 AM
Benjamin Summerton (define-private-public) updated the diff for D2364: Replacing UI_view2d_scrollsers_draw() to immedaite mode.
  • Horizontal scrolbars now use immedaite mode
  • vertical scrollbars now use immediate mode
Nov 18 2016, 5:02 AM
Benjamin Summerton (define-private-public) updated the diff for D2363: Moved UI_view2_multi_grid_draw() to Gawain.
  • Removed some unecessary comments
Nov 18 2016, 4:50 AM · BF Blender: 2.8
Benjamin Summerton (define-private-public) updated the diff for D2363: Moved UI_view2_multi_grid_draw() to Gawain.
  • Added a line drawing optimization
Nov 18 2016, 4:49 AM · BF Blender: 2.8
Benjamin Summerton (define-private-public) updated the diff for D2360: Moved UI_view2d_grid_draw() to immediate functions.
  • changed variable to a better name
  • Merwin told me adding the skips would make it faster
Nov 18 2016, 4:43 AM
Benjamin Summerton (define-private-public) retitled D2364: Replacing UI_view2d_scrollsers_draw() to immedaite mode from to Replacing UI_view2d_scrollsers_draw() to immedaite mode.
Nov 18 2016, 4:28 AM
Benjamin Summerton (define-private-public) updated the diff for D2363: Moved UI_view2_multi_grid_draw() to Gawain.
  • Makes an estimate of how many vertices are needed
Nov 18 2016, 3:56 AM · BF Blender: 2.8
Benjamin Summerton (define-private-public) added a comment to D2363: Moved UI_view2_multi_grid_draw() to Gawain.

Having two very similar for loops in this function doesn't seem that elegant. Can anyone recommend any alternatives?

Nov 18 2016, 2:59 AM · BF Blender: 2.8
Benjamin Summerton (define-private-public) retitled D2363: Moved UI_view2_multi_grid_draw() to Gawain from GL calls replaced, but it's buggy. Working on a fix to Moved UI_view2_multi_grid_draw() to Gawain.
Nov 18 2016, 2:55 AM · BF Blender: 2.8
Benjamin Summerton (define-private-public) updated the diff for D2363: Moved UI_view2_multi_grid_draw() to Gawain.
  • Fixed the bug,
Nov 18 2016, 2:52 AM · BF Blender: 2.8
Benjamin Summerton (define-private-public) retitled D2363: Moved UI_view2_multi_grid_draw() to Gawain from to GL calls replaced, but it's buggy. Working on a fix.
Nov 18 2016, 2:40 AM · BF Blender: 2.8
Benjamin Summerton (define-private-public) updated the diff for D2360: Moved UI_view2d_grid_draw() to immediate functions.
  • Merge branch 'blender2.8' into imm.view2d.c.UI_view2d_grid_draw
  • Add a fix to for the minor vertical gridlines
Nov 18 2016, 2:02 AM

Nov 17 2016

Benjamin Summerton (define-private-public) updated the diff for D2360: Moved UI_view2d_grid_draw() to immediate functions.
  • Added a check to exit early if there is nothing to draw
Nov 17 2016, 12:52 AM
Benjamin Summerton (define-private-public) updated the diff for D2360: Moved UI_view2d_grid_draw() to immediate functions.
  • Merge branch 'blender2.8' into imm.view2d.c
  • accidentally was using float instead of unsgined bytes for colors
  • Should be using a flat shader instead
  • Changed naming convenstions of variables
Nov 17 2016, 12:48 AM

Nov 16 2016

Benjamin Summerton (define-private-public) added a reviewer for D2360: Moved UI_view2d_grid_draw() to immediate functions: Anthony Edlin (krash).

You're akrashe in IRC, right? You said you wanted to review this.

Nov 16 2016, 7:52 AM
Benjamin Summerton (define-private-public) retitled D2360: Moved UI_view2d_grid_draw() to immediate functions from to Moved UI_view2d_grid_draw() to immediate functions.
Nov 16 2016, 7:48 AM
Benjamin Summerton (define-private-public) abandoned D2357: added arcanist.

Crap, diffed the wrong thing...

Nov 16 2016, 4:04 AM
Benjamin Summerton (define-private-public) added a comment to D2357: added arcanist.

Crap, diffed the wrong thing...

Nov 16 2016, 4:03 AM
Benjamin Summerton (define-private-public) retitled D2357: added arcanist from to added arcanist.
Nov 16 2016, 4:02 AM

Nov 15 2016

Benjamin Summerton (define-private-public) added a comment to T49043: replace OpenGL immediate mode in Blender 2.8.

Does view2d.c have any takers?

Nov 15 2016, 4:01 AM · EEVEE & Viewport, BF Blender: 2.8
Benjamin Summerton (define-private-public) added a comment to T49043: replace OpenGL immediate mode in Blender 2.8.

Does anyone mind if I claim source/blender/editors/space_action/action_draw.c?

Nov 15 2016, 3:40 AM · EEVEE & Viewport, BF Blender: 2.8