I've checked this patch and disabling multitouch gestures makes Blender ignore all gestures. I think that's because Windows knows Blender can accept DM gestures and sends them, but they are not processed in driveTrackpad method. If you don't respond to DM check, Windows sends non-DM events instead and trackpad works the old way: P3202.

• Fix Metal compile error

• All test are passing now
• Merge branch 'master' into cycles-add-scene-linear-color-type

One more test left to fix.

• Fix many failing tests
• Implement bssrdf_sample, automatic closure size

• Fix unitialized variable, simplify code
• Possible fix for oneAPI compilation error
• Move spectrum conversion functions into kernel/util/color.h

• Rename SceneLinearColor to Spectrum
• Rename macros

In D15535#421266, @Brecht Van Lommel (brecht) wrote:

Thanks!

I would like to find a different name than SceneLinearColor for this, since I don't think the distinguishing feature is that this color is in scene linear color space.

In PBRT this is called Spectrum, what do you think about that? Or perhaps SpectrumColor if you think that's more clear.

• Format code
• Fix compilation on CUDA

In D15525#421159, @Sergey Sharybin (sergey) wrote:

What is the bigger goal this patch is leading to? How using float8 will help for color operations?

• Fix compilation errors with Metal and SSE

• Fix compilation errors with NEON and SSE3

Thanks @Brecht Van Lommel (brecht) @Thomas Dinges (dingto)!

@Pratik Borhade (PratikPB2123) that's right. The gestures now behave the same way they do on macOS on supported Windows precision touchpads.

Hi, you can hold down Ctrl key while sliding up/down with two fingers to zoom in or out. This gesture is now much smoother than it used to be and allows more precise control.

Thanks for helping me complete this patch! I'm glad I can contribute this feature to Blender.

• Merge branch 'master' into precision-touchpad

• Listen for scroll direction changes in registry

In D7660#385490, @Nicholas Rishel (nicholas_rishel) wrote:

GHOST_DirectManipulationHelper would be my first guess too. I'm not sure how the async modifier for RegNotifyChangeKeyValue works, so that modifier might change what works best for the code. I think you'll better understand that once you dive into the question. :)

• Load scroll direction value from registry when initializing touchpad
• Merge branch 'master' into precision-touchpad

Yeah, I'll do it. Where would you suggest putting registry-related code in? GHOST_DirectManipulationHelper seems to be the right place.

Holding control or command while panning on macOS results in zooming, the same is also true on Windows. I can't test which events are generated on macOS, but I don't think that pressing any buttons on a keyboard would affect a touchpad in any way.

• Fix inverted rotation direction in 3D viewport

In D7660#382852, @Nicholas Rishel (nicholas_rishel) wrote:

I was already discussing the issue with some developers with MacBooks handy, but if you have a MacBook and would prefer to investigate please do so.

@Nicholas Rishel (nicholas_rishel) can you please commit the patch? I don't have the commit rights.

• Merge branch 'master' into precision-touchpad
• Fix initialization order warning

• Merge branch 'master' into precision-touchpad
• Update license headers
• Move trackpad event creation code to separate function
• Initialize m_directManipulationHelper to null in GHOST_WindowWin32's constructor
• Use different creation pattern for GHOST_DirectManipulationHelper to avoid partially initialized state

• Store DPI value in GHOST_DirectManipulationViewportEventHandler
• Rename macro
• Update DM only when active
• Move event creation out of Window class

There's one significant change I'd like to see, I don't think the trackpad should be holding onto a pointer to the window. I haven't fully considered what changes would be necessary, but at a high level I suspect that would mean returning event data to the GHOST_SystemWin32 to generate events instead of generating them directly in the trackpad.

• Merge branch 'master' into precision-touchpad
• Remove SAL annotations
• Don't store System and HWND in classes
• Remove redundant comment
• Document gesture state machine
• Don't check for NULL when deleting
• Use factory method to create DirectManipulationHelper
• Declare variables where used, use static_cast, const
• Silence unused variable warnings

@Nicholas Rishel (nicholas_rishel) could you please review the patch?

• Merge branch 'master' into precision-touchpad

Diffed against wrong branch

Pushed wrong branch

Cycles: Support merging images rendered with adaptive sampling

Yes, I don't have commit rights. Thanks!

• Fix start_sample_ used instead of sample_offset_