Home
Search
Configure Global Search
Log In
Transactions
D10959
Change Details
Change Details
Old
New
Diff
{F9932853 size=full} This patch adds support for filtering out rows based on rules and values. Filters will work for any attribute data source, they are a property of the spreadsheet rather than of the attribute system. The properties displayed in the row filter can depend on data type of the currently visible column with that name. If the name is no longer visible, the row filter will remember its data type until a column with that name is visible again. **Implementation Questions** * The comments in `screen.c` combined with tagging the sidebar for redraw after the main region point to a lack of understanding or some technical debt, not sure. **Future Improvements** * This patch doesn't contain a search of visible columns when adding a new filter. That's separate enough that I think it makes sense to push that with a separate patch later. * Filtering based on instance names could be added as a separate patch or included in this patch, it isn't currently though. This patch is available in the `temp-spreadsheet-row-filter` branch.
{F9932853 size=full} This patch adds support for filtering out rows based on rules and values. Filters will work for any attribute data source, they are a property of the spreadsheet rather than of the attribute system. The properties displayed in the row filter can depend on data type of the currently visible column with that name. If the name is no longer visible, the row filter will remember its data type until a column with that name is visible again. **Implementation Questions** * The comments in `screen.c` combined with tagging the sidebar for redraw after the main region point to a lack of understanding or some technical debt, not sure. **Future Improvements** * This patch doesn't contain a search of visible columns when adding a new filter. That's separate enough that I think it makes sense to push that with a separate patch later. This patch is available in the `temp-spreadsheet-row-filter` branch.
{F9932853 size=full} This patch adds support for filtering out rows based on rules and values. Filters will work for any attribute data source, they are a property of the spreadsheet rather than of the attribute system. The properties displayed in the row filter can depend on data type of the currently visible column with that name. If the name is no longer visible, the row filter will remember its data type until a column with that name is visible again. **Implementation Questions** * The comments in `screen.c` combined with tagging the sidebar for redraw after the main region point to a lack of understanding or some technical debt, not sure. **Future Improvements** * This patch doesn't contain a search of visible columns when adding a new filter. That's separate enough that I think it makes sense to push that with a separate patch later.
* Filtering based on instance names could be added as a separate patch or included in this patch, it isn't currently though.
This patch is available in the `temp-spreadsheet-row-filter` branch.
Continue