Change Details

The real issue seems to be that update functions defined in `rna_def_fmodifier_envelope_ctrl` are actually never called. [we have a bunch of `rna_FModifier_update` defined there -- if that would be called I assume we would be good...] So, while it is unclear why exactly this is not called [`ui_apply_but_funcs_after` checks for `after.rnapoin.data` -- this is NULL here -- can only guess this is because it is a nested struct?], we already have some kind of bandaid fix in place: relevant commit: - rB9a88bd55903a related Diff - D2118 This patch only piggybacks on said bandaid fix, I am not sure if this is really the best fix though... (seems quite strange to me that we need to manually go in UI code and enforce updates there?)

Issue is that update functions defined in `rna_def_fmodifier_envelope_ctrl` (namely `rna_FModifier_update`) are actually never called. This is because UI code for FCurve modifiers often does not use RNA buttons but uses custom update functions (or non at all). For example, rB9a88bd55903a did this for the generators, envelope control points did not have this at all. This is now changed to use RNA buttons for the envelope control points, this could done for other non-RNA buttons as well to get rid of 'validate_fmodifier_cb()'.

The real iIssue seems to beis that update functions defined in `rna_def_fmodifier_envelope_ctrl` are actually never called.(namely `rna_FModifier_update`) are [we have a bunch of `rna_FModifier_update` defined there -- if that would be called I assume we would be good...]actually never called. So, while it is unclear why exactly this is not called [`ui_apply_but_funcs_after` checks for `after.rnapoin.data` -- this is NULL here -- can only guess this is because it is a nested struct?], we already have some kind of bandaid fix in place: relevant commit:This is because UI code for FCurve modifiers often does not use RNA - rB9a88bd55903abuttons but uses custom update functions (or non at all). For example, related DiffrB9a88bd55903a did this for the generators, envelope control points did - D2118not have this at all. This patch only piggybacks on said bandaid fix, I am not sure if this isis now changed to use RNA buttons for the envelope control points, really the best fix though... (seems quite strange to me that we need tothis could done for other non-RNA buttons as well to get rid of manually go in UI code and enforce updates there?)'validate_fmodifier_cb()'.