Change Details

Previously there was a special extraction process for "vertex colors" that copied the color data to the GPU with a special format. Instead, this patch replaces this with use of the generic attribute extraction. This reduces the number of code paths, allowing easier optimization in the future. --- Currently this works for sculpt mode, but not texture paint mode or object mode. I'm struggling to figure out how the shader groups and GPU batches actually choose which vertex buffer to use in the shader.

Previously there was a special extraction process for "vertex colors" that copied the color data to the GPU with a special format. Instead, this patch replaces this with use of the generic attribute extraction. This reduces the number of code paths, allowing easier optimization in the future. To make it possible to use the generic extraction system for attributes but also assign aliases for use by shaders, some changes are necessary. First, the GPU material attribute can now store whether it actually refers to the default color attribute, rather than a specific name. This replaces the hack to use `CD_MCOL` in the color attribute shader node. Second, the extraction code checks the names against the default and active names and marks the requests if they correspond. --- Currently this works for sculpt mode, but not texture paint mode or object mode. Some change is still missing for complete support yet, but I'm not sure where a change is missing.

Previously there was a special extraction process for "vertex colors" that copied the color data to the GPU with a special format. Instead, this patch replaces this with use of the generic attribute extraction. This reduces the number of code paths, allowing easier optimization in the future. To make it possible to use the generic extraction system for attributes but also assign aliases for use by shaders, some changes are necessary. First, the GPU material attribute can now store whether it actually refers to the default color attribute, rather than a specific name. This replaces the hack to use `CD_MCOL` in the color attribute shader node. Second, the extraction code checks the names against the default and active names and marks the requests if they correspond. --- Currently this works for sculpt mode, but not texture paint mode or object mode. I'm struggling to figure out how the shader groups andSome change is still missing for complete support yet, GPU batches actually choose which vertex buffer to use in the shaderbut I'm not sure where a change is missing.